ux: filter findings, non-preview open, quieter copy toasts#21
Closed
dmartinochoa wants to merge 1 commit into
Closed
ux: filter findings, non-preview open, quieter copy toasts#21dmartinochoa wants to merge 1 commit into
dmartinochoa wants to merge 1 commit into
Conversation
Three small UX wins from the post-v0.2.0 review queue. Stacked on ux-polish-2 (#20). #5 — Filter the Findings tree - Pipeline-Check: Filter Findings command opens an InputBox; matches against rule ID, message body, and file path (case-insensitive substring). Re-invoke pre-fills the current filter so users can edit or clear (empty input clears). - New `$(filter)` button on the Findings view title bar. - FindingsTreeProvider gets getFilter/setFilter/applyFilter. The badge tracks the filtered count; `lastFindingUris` still tracks the unfiltered universe so a publish for a currently-hidden URI still wakes the tree up (otherwise a CLEAR of a filtered-out finding would never refresh). - 8 tests covering: default empty, rule-id match, case-insensitivity, message-body match, fsPath match, clear via empty string, whitespace trim, badge reflects filtered count. #4 — Open Finding (non-preview) - Pipeline-Check: Open Finding context-menu entry on tree leaves. Opens with `preview: false` — pins the file as a permanent tab so triaging multiple findings side-by-side doesn't create tab clutter. The single-click default still uses preview, keeping the common "scan through findings" flow lightweight. - LeafLike type widened to include `uri` and `diagnostic.range`. #7 — Quieter clipboard confirmations - Copy Rule ID and Copy LSP Install Command switch from showInformationMessage (modal toast) to setStatusBarMessage with a 2-second TTL (CONFIRM_TTL_MS). The copy succeeds silently 95% of the time anyway; the status bar confirmation reads without stealing focus. Wiring - package.json: three new command declarations; view/title button for filter (group navigation@1, between scan and changeGrouping); view/item/context entry for openNonPreview (group navigation@0, top of the menu); commandPalette gates the leaf-context commands to `false` so they don't show palette-wide without a node. - src/findingsView.ts: filter state + setFilter + getFilter + applyFilter (in findings()); sets the `pipelineCheck.filterActive` context key so future manifest contributions can paint a "filter active" affordance. - src/test/integration/activation.test.ts: command-registration expected list grows by filter + openNonPreview. Total: 137 tests pass (was 129 on #20; +8 filter behaviour). Lint, compile, smoke, integration-compile all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small UX wins from the post-v0.2.0 review queue. Stacked on #20 — base is `ux-polish-2`.
What landed
#5 — Filter the Findings tree
#4 — Open Finding (non-preview)
#7 — Quieter clipboard confirmations
Test plan
Notes
🤖 Generated with Claude Code